Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades mypy to version 0.971 #3952

Merged
merged 13 commits into from Aug 16, 2022
Merged

Upgrades mypy to version 0.971 #3952

merged 13 commits into from Aug 16, 2022

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jul 19, 2022

Fixes WB-NNNN
Fixes #NNNN

Description

  • Upgrade mypy to 0.971.
  • Remove module-level imports of parse_version from pkg_resources, which takes way too much time.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #3952 (72b6647) into master (c165a66) will increase coverage by 0.06%.
The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3952      +/-   ##
==========================================
+ Coverage   82.52%   82.59%   +0.06%     
==========================================
  Files         255      255              
  Lines       32351    32370      +19     
==========================================
+ Hits        26699    26737      +38     
+ Misses       5652     5633      -19     
Flag Coverage Δ
functest 54.76% <84.78%> (+0.03%) ⬆️
unittest 73.35% <84.78%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/docker/__init__.py 81.39% <0.00%> (ø)
wandb/docker/auth.py 51.32% <0.00%> (ø)
wandb/sdk/wandb_run.py 90.94% <75.00%> (+0.06%) ⬆️
wandb/apis/public.py 82.44% <100.00%> (+<0.01%) ⬆️
wandb/sdk/data_types/base_types/wb_value.py 93.87% <100.00%> (+0.06%) ⬆️
wandb/sdk/data_types/image.py 82.95% <100.00%> (+0.16%) ⬆️
wandb/sdk/internal/handler.py 90.94% <100.00%> (ø)
wandb/sdk/internal/internal_api.py 86.37% <100.00%> (+1.39%) ⬆️
wandb/sdk/internal/profiler.py 95.00% <100.00%> (ø)
wandb/sdk/internal/sender.py 90.97% <100.00%> (+0.01%) ⬆️
... and 26 more

@dmitryduev dmitryduev marked this pull request as ready for review August 12, 2022 08:12
@dmitryduev dmitryduev requested a review from a team as a code owner August 12, 2022 08:12
@dmitryduev dmitryduev changed the title Upgrade mypy to 0.961 Upgrades mypy to version 0.971 Aug 15, 2022
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@dmitryduev dmitryduev merged commit a354b18 into master Aug 16, 2022
@dmitryduev dmitryduev deleted the mypy-0.961 branch August 16, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants