Replaces unsafe yaml loaders with yaml.safe_load #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zythosec
commented
Jun 7, 2022
| @@ -1014,11 +1014,7 @@ def image_from_docker_args(args: List[str]) -> Optional[str]: | |||
|
|
|||
|
|
|||
| def load_yaml(file: Any) -> Any: | |||
| """If pyyaml > 5.1 use full_load to avoid warning""" | |||
There was a problem hiding this comment.
Open question: what warning was this? And do we actually use the functionality of full_load?
There was a problem hiding this comment.
It must have been a deprecation warning like shown here yaml/pyyaml#265
Codecov Report
@@ Coverage Diff @@
## master #3753 +/- ##
==========================================
+ Coverage 81.83% 81.84% +0.01%
==========================================
Files 241 241
Lines 29771 29769 -2
==========================================
+ Hits 24362 24364 +2
+ Misses 5409 5405 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dmitryduev
approved these changes
Jun 8, 2022
| @@ -1014,11 +1014,7 @@ def image_from_docker_args(args: List[str]) -> Optional[str]: | |||
|
|
|||
|
|
|||
| def load_yaml(file: Any) -> Any: | |||
| """If pyyaml > 5.1 use full_load to avoid warning""" | |||
There was a problem hiding this comment.
It must have been a deprecation warning like shown here yaml/pyyaml#265
kptkin
changed the title
kptkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-9909
Description
What does the PR do?
FullLoader and Loader should not be used on untrusted data. While it can be argued that the config file can be "trusted" data, this PR replaces unsafe yaml.full_load and yaml.load with yaml.safe_load to eliminate the possibility of a malicious config file being run causing arbitrary code execution.
Testing
How was this PR tested?
make testChecklist