New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
break gradient and parameters hooks #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3509 +/- ##
==========================================
- Coverage 82.70% 82.32% -0.38%
==========================================
Files 256 256
Lines 32512 32519 +7
==========================================
- Hits 26889 26772 -117
- Misses 5623 5747 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
changed the title
break gradient and parameters hooks
[WB-8217] break gradient and parameters hooks
Apr 28, 2022
kptkin
changed the title
[WB-8217] break gradient and parameters hooks
break gradient and parameters hooks
Aug 11, 2022
dmitryduev
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WB-8217
Description
What does the PR do?
Breaks the hooks for gradient and parameters. The hook for gradients seems to work with
jit
but the hook for parameters is currently can't be scripted. This PR doesn't fix the issue for people that want to track weights, but it help for people that want to track just gradients.Testing
How was this PR tested?
Checklist