Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break gradient and parameters hooks #3509

Merged
merged 10 commits into from Aug 17, 2022
Merged

break gradient and parameters hooks #3509

merged 10 commits into from Aug 17, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Apr 11, 2022

Fixes WB-8217

Description

What does the PR do?

Breaks the hooks for gradient and parameters. The hook for gradients seems to work with jit but the hook for parameters is currently can't be scripted. This PR doesn't fix the issue for people that want to track weights, but it help for people that want to track just gradients.

Testing

How was this PR tested?

Checklist

  • Name PR "[WB-NNNN][WB-MMMM] Add support for..." similar to entries in CHANGELOG.md
  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #3509 (0663de0) into master (fa8174f) will decrease coverage by 0.37%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3509      +/-   ##
==========================================
- Coverage   82.70%   82.32%   -0.38%     
==========================================
  Files         256      256              
  Lines       32512    32519       +7     
==========================================
- Hits        26889    26772     -117     
- Misses       5623     5747     +124     
Flag Coverage Δ
functest 54.23% <84.78%> (-0.78%) ⬇️
unittest 73.52% <93.47%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/wandb_torch.py 61.29% <94.11%> (+1.35%) ⬆️
wandb/sdk/wandb_watch.py 81.48% <100.00%> (+6.93%) ⬆️
wandb/integration/prodigy/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
wandb/integration/prodigy/prodigy.py 0.00% <0.00%> (-95.00%) ⬇️
wandb/sdk/data_types/base_types/media.py 91.36% <0.00%> (-1.44%) ⬇️
wandb/sdk/wandb_run.py 91.18% <0.00%> (-0.19%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/lib/sock_client.py 92.08% <0.00%> (ø)
wandb/sdk/wandb_init.py 85.90% <0.00%> (+0.18%) ⬆️
wandb/sdk/wandb_setup.py 89.00% <0.00%> (+0.50%) ⬆️
... and 2 more

@kptkin kptkin changed the title break gradient and parameters hooks [WB-8217] break gradient and parameters hooks Apr 28, 2022
@kptkin kptkin marked this pull request as ready for review May 4, 2022 07:21
@kptkin kptkin requested review from raubitsj and dmitryduev May 4, 2022 07:21
@kptkin kptkin added this to the sdk-2022-06.1 milestone May 4, 2022
@raubitsj raubitsj modified the milestones: sdk-2022-06.1, sdk-2022-07.1 Jun 8, 2022
@raubitsj raubitsj modified the milestones: sdk-2022-07.1, sdk-2022-08.1 Jun 29, 2022
@kptkin kptkin modified the milestones: sdk-2022-08.1, sdk-2022-09.1 Jul 27, 2022
@kptkin kptkin changed the title [WB-8217] break gradient and parameters hooks break gradient and parameters hooks Aug 11, 2022
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wandb/sdk/wandb_watch.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants