Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sdk): temporarily pin jax in tests because of breaking changes #4632

Merged
merged 1 commit into from Dec 14, 2022

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Dec 14, 2022

Description

jax 0.4.1 changed something which is breaking our tests... temporarily pin so we can keep tests passing while we figure it out

Testing

circleci

@raubitsj raubitsj changed the title pin jax for now build(sdk): temporarily pin jax in tests because of breaking changes Dec 14, 2022
@raubitsj raubitsj marked this pull request as ready for review December 14, 2022 13:55
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #4632 (a2fe3cf) into main (39d50c3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4632      +/-   ##
==========================================
- Coverage   83.22%   83.20%   -0.02%     
==========================================
  Files         279      279              
  Lines       34903    34903              
==========================================
- Hits        29047    29041       -6     
- Misses       5856     5862       +6     
Flag Coverage Δ
functest 56.10% <ø> (+<0.01%) ⬆️
unittest 73.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/integration/tensorboard/monkeypatch.py 91.35% <0.00%> (-2.47%) ⬇️
wandb/sdk/lib/sock_client.py 93.12% <0.00%> (-1.06%) ⬇️
wandb/sdk/lib/printer.py 88.60% <0.00%> (-0.64%) ⬇️
wandb/sdk/lib/git.py 77.71% <0.00%> (-0.61%) ⬇️
wandb/util.py 87.29% <0.00%> (-0.41%) ⬇️
wandb/sdk/wandb_run.py 90.60% <0.00%> (-0.06%) ⬇️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

Copy link
Contributor

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@philipjball
Copy link

I believe this might be related to the recent API changes here, where everything is now a jax.Array, subsuming jax.DeviceArray.

In any case, Jax 0.4.1 breaks logging because Jax arrays no longer pass the typename check in util.py.

@dmitryduev
Copy link
Member

thanks @philipjball, will fix!

@dmitryduev
Copy link
Member

hey @philipjball, the fix should be in main -- would you mind checking that it works for you with jax==0.4.1?

@philipjball
Copy link

Yep works perfectly for me! Thanks for fixing that so quickly :) Below is just a mockup of two jax Arrays I've logged successfully using 0.4.1:
image

@kptkin kptkin added this to the sdk-2023-01.1 milestone Jan 5, 2023
@kptkin kptkin added the changelog-ignore Ignore PR from changelog label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc-build changelog-ignore Ignore PR from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants