Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pulling sweeps optional when using public api to query for runs #4186

Merged
merged 7 commits into from Sep 7, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 26, 2022

Fixes WB-9297

Description

What does the PR do?

This PR allows users to specify if they want to pull the sweeps (when pulling the runs) with the Api.runs method. The default stays True for backward compatibility, however the user could specify Api.runs(..., include_sweeps=False) in case they don't need sweeps and save time. From my simple example it seems to reduce the fetch time by ~3.6-5.9x.

Testing

How was this PR tested?

Manually

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #4186 (72b4de9) into master (dfbcbb7) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 72b4de9 differs from pull request most recent head 85d225c. Consider uploading reports for the commit 85d225c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
+ Coverage   82.54%   82.68%   +0.14%     
==========================================
  Files         256      256              
  Lines       32612    32602      -10     
==========================================
+ Hits        26918    26957      +39     
+ Misses       5694     5645      -49     
Flag Coverage Δ
functest 55.98% <50.00%> (+0.11%) ⬆️
unittest 73.45% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 82.58% <100.00%> (+0.28%) ⬆️
wandb/filesync/step_prepare.py 93.67% <0.00%> (-1.27%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/util.py 87.24% <0.00%> (-0.03%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (ø)
wandb/cli/cli.py 68.89% <0.00%> (+0.09%) ⬆️
wandb/sdk/wandb_run.py 91.13% <0.00%> (+0.23%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
... and 4 more

@kptkin kptkin marked this pull request as ready for review August 26, 2022 03:51
@kptkin kptkin changed the title make sweeps optional make pulling sweeps optional when using public api to query for runs Aug 26, 2022
@kptkin kptkin requested a review from a team August 26, 2022 20:49
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wandb/apis/public.py Show resolved Hide resolved
@dmitryduev
Copy link
Member

One comment: can we properly test this now?

@kptkin
Copy link
Contributor Author

kptkin commented Aug 26, 2022

One comment: can we properly test this now?

Do you mean performance test? Or that we don’t pull the sweep info?

@dmitryduev
Copy link
Member

@kptkin: just that we don't pull in the info

@dmitryduev dmitryduev added this to the sdk-2022-09.1 milestone Sep 6, 2022
@dmitryduev dmitryduev merged commit 643b25d into master Sep 7, 2022
@dmitryduev dmitryduev deleted the WB-9297 branch September 7, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants