Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix dangerously error on landing #75

Merged
merged 2 commits into from Feb 29, 2024

Conversation

matthieuauger
Copy link
Contributor

@matthieuauger matthieuauger commented Feb 28, 2024

Fix #50 based on this ReactTooltip/react-tooltip#587 (comment)

After this error, there was another server-rendering issue with react-select “Warning: Prop id did not match” that I fixed with a fixed instanceId. A better fix would be to use the useId() hook but it's only available on React 18.

import React, { useId } from 'react';

There is one remaining issue for mac devices only I think Extra attributes from the server: aria-activedescendant.
Everything seems linked to the fact that react-select does not render isomorphically.

There is an attempt to fix it specifically here, I'd suggest to wait and see if the PR get merged

@matthieuauger matthieuauger requested a review from a team as a code owner February 28, 2024 16:19
@matthieuauger matthieuauger changed the title Fix dangerously error [fix] fix dangerously error on landing Feb 28, 2024
@remybar
Copy link
Contributor

remybar commented Feb 29, 2024

lgtm !

I'm on macos and I confirm that I have the aria-activedescendant issue.

Thanks for your work @matthieuauger !

@mazurroman
Copy link
Contributor

Warm welcome to the Walnut community and thank you for your contribution @matthieuauger ! Feel free to join our contributor telegram chat here: https://t.me/+DYI4FMia43I1NDI8

I will create a new issue to bump React to 18 and switch to useId(). We should also keep an eye on JedWatson/react-select#5859 and fix when ready so thanks for linking

@mazurroman mazurroman merged commit 904a9e8 into walnuthq:main Feb 29, 2024
1 check passed
@VeryDustyBot VeryDustyBot mentioned this pull request Feb 29, 2024
@mazurroman mazurroman mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix console error
3 participants