New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tcell with roll-our-own #42
Conversation
f64b054
to
ac962d3
Compare
@89z thanks! I excluded SIGWINCH handling on Windows, if you could make another try that would be awesome! |
047ac4b
to
5e31eb0
Compare
Build + unit testing now pass on Windows, I added a Travis config so any breakage should become obvious. Could still be visually all-broken though, needs testing by a human on an actual Windows machine. Just starting
... should cover most Windows specific cases. |
c3c9c34
to
7cd1571
Compare
I think it's because of this, no explicit access to Lines 105 to 114 in 7cd1571
I'll see if I can figure out some way of testing this on Windows somehow. |
9ce1869
to
3eb3f58
Compare
3eb3f58
to
c4bdcad
Compare
Found a Windows machine, will fix things up there. |
Before this change, the main loop was roughly:
With this change in place, the main loop is:
The difference is huge if you do a fling scroll on a trackpad. Before, scrolling was slow at constant speed, and the scrolling kept on at that slow constant speed way longer than what it should have. Now, scrolling feels just like it should.