Added validation for S3 credentials #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Themplarer
force-pushed
the
s3-credentials-validation
branch
2 times, most recently
from
2b6bbf5
to
5ac62e8
Compare
Themplarer
force-pushed
the
s3-credentials-validation
branch
from
5ac62e8
to
712f062
Compare
debebantur
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
Any DB
Pull request description
Describe what this PR fix
There was no credentials checks, so some operations took minutes to run, even though credentials were incorrect.
I introduced function for
Foldervalidation. It can be useful for other storages.Resolves #1010, #1080