Update golangci-lint version to 1.50.1 (#1381)

* Update golangci-lint version to 1.50.1

Remove deprecated lints: golangci/golangci-lint#3125
Re-enable gocritic features which previously didn't support generics

* gofmt

* Pass PrevBackupInfo by reference as it is 232 bytes

.github/workflows/golangci-lint.yml

@@ -27,4 +27,4 @@ jobs:
         uses: golangci/golangci-lint-action@v3.3.1
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.46.2
+          version: v1.50.1

.golangci.yml

@@ -17,12 +17,9 @@ linters-settings:
       - experimental
       - opinionated
       - style
-    disabled-checks:
-      - hugeParam
-      - rangeValCopy
-    # settings:
-    #   hugeParam:
-    #     sizeThreshold: 170 # temporary, default is 80
+    settings:
+      hugeParam:
+        sizeThreshold: 170 # temporary, default is 80
   gocyclo:
     min-complexity: 15
   govet:
@@ -77,14 +74,11 @@ linters:
     - nakedret
     - revive
     - staticcheck
-    # - structcheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
     - lll
-    - deadcode
     - stylecheck
     - gosimple
     - whitespace
@@ -108,5 +102,5 @@ severity:
   rules:
     - linters:
       - godox
-      - deadcode
+      - unused
       severity: info

internal/backup.go

@@ -9,7 +9,7 @@ import (
 	"github.com/wal-g/wal-g/utility"
 )
 
-//region errors
+// region errors
 type SentinelMarshallingError struct {
 	error
 }

internal/backup_mark.go

@@ -119,7 +119,7 @@ func (h *BackupMarkHandler) getBackupsToMarkImpermanent(backupName string) ([]st
 	return []string{meta.BackupName}, nil
 }
 
-//backup has permanent in future only when one of the next backups is permanent
+// backup has permanent in future only when one of the next backups is permanent
 func backupHasPermanentInFuture(reverseLinks *map[string][]string,
 	backupName string,
 	permanentBackups *map[string]bool) bool {
@@ -138,7 +138,7 @@ func backupHasPermanentInFuture(reverseLinks *map[string][]string,
 	return false
 }
 
-//return graph where nodes - backup names, edges - links from base backups to increment backups
+// return graph where nodes - backup names, edges - links from base backups to increment backups
 func (h *BackupMarkHandler) getGraphFromBaseToIncrement() (map[string][]string, error) {
 	backups, err := GetBackups(h.baseBackupFolder)
 	if err != nil {

internal/databases/greenplum/ao_storage.go

@@ -30,7 +30,7 @@ func makeDeltaAoFileStorageKey(baseKey string, modCount int64) string {
 	return fmt.Sprintf("%s%s%d%s", trimmedKey, AoSegDeltaDelimiter, modCount, AoSegSuffix)
 }
 
-//LoadStorageAoFiles loads the list of the AO/AOCS segment files that are referenced from previous backups
+// LoadStorageAoFiles loads the list of the AO/AOCS segment files that are referenced from previous backups
 func LoadStorageAoFiles(baseBackupsFolder storage.Folder) (map[string]struct{}, error) {
 	aoSegments := make(map[string]struct{}, 0)
 

internal/databases/greenplum/backup_push_handler.go

@@ -222,7 +222,7 @@ func (bh *BackupHandler) HandleBackupPush() {
 	bh.currBackupInfo.segmentsMetadata, err = bh.fetchSegmentBackupsMetadata()
 	tracelog.ErrorLogger.FatalOnError(err)
 
-	sentinelDto := NewBackupSentinelDto(bh.currBackupInfo, bh.prevBackupInfo,
+	sentinelDto := NewBackupSentinelDto(bh.currBackupInfo, &bh.prevBackupInfo,
 		restoreLSNs, bh.arguments.userData, bh.arguments.isPermanent)
 	err = bh.uploadSentinel(sentinelDto)
 	if err != nil {

internal/databases/greenplum/backup_sentinel_dto.go

@@ -98,7 +98,7 @@ func (s *BackupSentinelDto) String() string {
 }
 
 // NewBackupSentinelDto returns new BackupSentinelDto instance
-func NewBackupSentinelDto(currBackupInfo CurrBackupInfo, prevBackupInfo PrevBackupInfo, restoreLSNs map[int]string, userData interface{},
+func NewBackupSentinelDto(currBackupInfo CurrBackupInfo, prevBackupInfo *PrevBackupInfo, restoreLSNs map[int]string, userData interface{},
 	isPermanent bool) BackupSentinelDto {
 	hostname, err := os.Hostname()
 	if err != nil {

internal/databases/greenplum/configure.go

@@ -32,7 +32,7 @@ func ConfigureSegContentID(contentIDFlag string) (int, error) {
 	return contentID, nil
 }
 
-//initGpLog is required for gp-common-go library to function properly
+// initGpLog is required for gp-common-go library to function properly
 func initGpLog(logsDir string) {
 	gplog.SetLogFileNameFunc(func(program, logdir string) string {
 		return fmt.Sprintf("%s/%s-gplog.log", logdir, program)

internal/databases/greenplum/generic_meta_interactor.go

@@ -24,7 +24,7 @@ func NewGenericMetaFetcher() GenericMetaFetcher {
 	return GenericMetaFetcher{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (mf GenericMetaFetcher) Fetch(backupName string, backupFolder storage.Folder) (internal.GenericMetadata, error) {
 	var backup = internal.NewBackup(backupFolder, backupName)
 	var sentinel BackupSentinelDto
@@ -52,7 +52,7 @@ func NewGenericMetaSetter() GenericMetaSetter {
 	return GenericMetaSetter{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.Folder, userData interface{}) error {
 	modifier := func(dto BackupSentinelDto) BackupSentinelDto {
 		dto.UserData = userData
@@ -61,7 +61,7 @@ func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.
 	return modifyBackupSentinel(backupName, backupFolder, modifier)
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetIsPermanent(backupName string, backupFolder storage.Folder, isPermanent bool) error {
 	modifier := func(dto BackupSentinelDto) BackupSentinelDto {
 		dto.IsPermanent = isPermanent

internal/databases/mongo/archive/layout.go

@@ -144,7 +144,7 @@ func SplitPurgingOplogArchivesByTS(archives []models.Archive, purgeBeforeTS mode
 	return purge
 }
 
-//OldestBackupAfterTime returns last backup after given time.
+// OldestBackupAfterTime returns last backup after given time.
 func OldestBackupAfterTime(backups []*models.Backup, after time.Time) (*models.Backup, error) {
 	if len(backups) <= 0 {
 		return nil, fmt.Errorf("empty backup list received")

internal/databases/mongo/archive/loader.go

@@ -100,7 +100,7 @@ func (sd *StorageDownloader) LoadBackups(names []string) ([]*models.Backup, erro
 	return backups, nil
 }
 
-//ListBackups lists backups in folder
+// ListBackups lists backups in folder
 func (sd *StorageDownloader) ListBackups() ([]internal.BackupTime, []string, error) {
 	return internal.GetBackupsAndGarbage(sd.backupsFolder)
 }

internal/databases/mysql/generic_meta_interactor.go

@@ -24,7 +24,7 @@ func NewGenericMetaFetcher() GenericMetaFetcher {
 	return GenericMetaFetcher{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (mf GenericMetaFetcher) Fetch(backupName string, backupFolder storage.Folder) (internal.GenericMetadata, error) {
 	var backup = internal.NewBackup(backupFolder, backupName)
 	var sentinel StreamSentinelDto
@@ -52,7 +52,7 @@ func NewGenericMetaSetter() GenericMetaSetter {
 	return GenericMetaSetter{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.Folder, userData interface{}) error {
 	modifier := func(dto StreamSentinelDto) StreamSentinelDto {
 		dto.UserData = userData
@@ -61,7 +61,7 @@ func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.
 	return modifyBackupSentinel(backupName, backupFolder, modifier)
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetIsPermanent(backupName string, backupFolder storage.Folder, isPermanent bool) error {
 	modifier := func(dto StreamSentinelDto) StreamSentinelDto {
 		dto.IsPermanent = isPermanent

internal/databases/postgres/generic_meta_interactor.go

@@ -24,7 +24,7 @@ func NewGenericMetaFetcher() GenericMetaFetcher {
 	return GenericMetaFetcher{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (mf GenericMetaFetcher) Fetch(backupName string, backupFolder storage.Folder) (internal.GenericMetadata, error) {
 	var backup = NewBackup(backupFolder, backupName)
 	meta, err := backup.FetchMeta()
@@ -51,7 +51,7 @@ func NewGenericMetaSetter() GenericMetaSetter {
 	return GenericMetaSetter{}
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.Folder, userData interface{}) error {
 	modifier := func(dto ExtendedMetadataDto) ExtendedMetadataDto {
 		dto.UserData = userData
@@ -60,7 +60,7 @@ func (ms GenericMetaSetter) SetUserData(backupName string, backupFolder storage.
 	return modifyBackupMetadata(backupName, backupFolder, modifier)
 }
 
-//TODO: Unit tests
+// TODO: Unit tests
 func (ms GenericMetaSetter) SetIsPermanent(backupName string, backupFolder storage.Folder, isPermanent bool) error {
 	modifier := func(dto ExtendedMetadataDto) ExtendedMetadataDto {
 		dto.IsPermanent = isPermanent

internal/databases/postgres/physical_slot.go

@@ -21,7 +21,7 @@ type PhysicalSlot struct {
 	RestartLSN pglogrepl.LSN
 }
 
-//NewPhysicalSlot is a helper function to declare a new PhysicalSlot object and set vaues from the parsed arguments
+// NewPhysicalSlot is a helper function to declare a new PhysicalSlot object and set vaues from the parsed arguments
 func NewPhysicalSlot(name string, exists bool, active bool, restartLSN string) (slot PhysicalSlot, err error) {
 	err = ValidateSlotName(name)
 	if err != nil {

internal/databases/postgres/tarball_streamer.go

@@ -90,7 +90,7 @@ func NewTarballStreamer(input io.Reader, maxTarSize int64, bundleFiles internal.
 	return streamer
 }
 
-//NextInputFile is what makes the TarballStreamer move to the next file.
+// NextInputFile is what makes the TarballStreamer move to the next file.
 func (streamer *TarballStreamer) NextInputFile() (err error) {
 	// First output tar, or switching to next
 	if streamer.outputTar == nil {
@@ -117,7 +117,7 @@ func (streamer *TarballStreamer) NextInputFile() (err error) {
 	return streamer.addFile()
 }
 
-//addFile adds the new file to the stream
+// addFile adds the new file to the stream
 func (streamer *TarballStreamer) addFile() (err error) {
 	if streamer.tarFileReadIndex+streamer.curHeader.Size > streamer.maxTarSize {
 		if streamer.tarFileReadIndex > 0 {
@@ -155,14 +155,14 @@ func (streamer *TarballStreamer) addFile() (err error) {
 	return nil
 }
 
-//remap rebuilds the name of the file according to remapping rules
+// remap rebuilds the name of the file according to remapping rules
 func (streamer *TarballStreamer) remap() {
 	for _, remap := range streamer.Remaps {
 		streamer.curHeader.Name = remap.from.ReplaceAllString(streamer.curHeader.Name, remap.to)
 	}
 }
 
-//readFileData reads the data from a tarred file
+// readFileData reads the data from a tarred file
 func (streamer *TarballStreamer) readFileData() (err error) {
 	err = streamer.NextInputFile()
 	if err != nil && err != errTarInputHeaderAlreadySet {
@@ -195,7 +195,7 @@ func (streamer *TarballStreamer) readFileData() (err error) {
 	return err
 }
 
-//pipeFileData calls readFileData to read file data from tar and then writes it to output tar writer
+// pipeFileData calls readFileData to read file data from tar and then writes it to output tar writer
 func (streamer *TarballStreamer) pipeFileData() (err error) {
 	if streamer.outputIo.Len() > 0 {
 		// There is still data in the buffer. Just stream that.
@@ -228,7 +228,7 @@ func (streamer *TarballStreamer) pipeFileData() (err error) {
 	return nil
 }
 
-//Read is what makes the TarballStreamer an io.Reader, which can be handled by WalUploader.UploadFile.
+// Read is what makes the TarballStreamer an io.Reader, which can be handled by WalUploader.UploadFile.
 func (streamer *TarballStreamer) Read(p []byte) (n int, err error) {
 	// Handle next file header if needed, read file data if needed, and write to output tar writer
 	err = streamer.pipeFileData()

internal/databases/postgres/timeline_history.go

@@ -43,7 +43,7 @@ type TimeLineHistFile struct {
 	readIndex  int
 }
 
-//NewTimeLineHistFile is a helper function to define a new TimeLineHistFile
+// NewTimeLineHistFile is a helper function to define a new TimeLineHistFile
 func NewTimeLineHistFile(timelineid uint32, filename string, body []byte) (TimeLineHistFile, error) {
 	tlh := TimeLineHistFile{TimeLineID: timelineid, Filename: filename, data: body}
 	return tlh, nil

internal/databases/redis/redis.go

@@ -18,7 +18,7 @@ func GetSettingWithLocalDefault(key string, defaultValue string) string {
 	return defaultValue
 }
 
-//getRedisConnection
+// getRedisConnection
 func _() *redis.Client {
 	redisAddr := GetSettingWithLocalDefault("WALG_REDIS_HOST", "localhost")
 	redisPort := GetSettingWithLocalDefault("WALG_REDIS_PORT", "6379")