Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to use gopkg.in/ini.v1 when saving config file #588

Merged
merged 1 commit into from Nov 28, 2021
Merged

Conversation

gandarez
Copy link
Member

This PR adds back gopkg.in/ini.v1 and removes pkg/ini custom ini parser. The lib now won't change the indentation of multiline python strings.

For further reference please see this PR.

@gandarez gandarez self-assigned this Nov 28, 2021
@gandarez gandarez added this to In progress in wakatime-cli via automation Nov 28, 2021
@alanhamlett
Copy link
Member

Looks like we need two testdata files, one for Windows and one for Linux/Mac, because the library is writing the Windows version with \r\n line endings.

@gandarez gandarez merged commit cd682be into develop Nov 28, 2021
@gandarez gandarez deleted the feature/ini branch November 28, 2021 20:41
wakatime-cli automation moved this from In progress to Done Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
wakatime-cli
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants