This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Add set text analyser for Coq lexer #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
force-pushed
the
coq-lexer-text-analysis
branch
from
dc6ead2
to
96f964b
Compare
dron22
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
LGTM. Just mind your PR descriptions here and in pygments PR. The order of Qed and qed has to be the other way around. Should be:
The current Coq analysis the actual value for completing a proof is `qed` but also `Qed` can appear on it. So I applied a regex to validate it.
Actually what's in the documentation is |
dron22
pushed a commit
that referenced
this pull request
Dec 8, 2020
Add set text analyser for Coq lexer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports pygments Coq text analysis to chroma/go. Original code can be found at: https://github.com/pygments/pygments/blob/master/pygments/lexers/theorem.py#L156
In the current pygments analysis the actual value for completing a proof is
Qedbut alsoqedcan appear on it. So I applied a regex to validate it. Also opened a PR to fix it on Pygments.https://coq.inria.fr/refman/proof-engine/proof-handling.html?highlight=qed#coq:cmd.qed
https://coq.inria.fr/refman/proof-engine/tactics.html#coq:tacn.tauto
Fixes: wakatime/wakatime-cli#93