This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Add set text analyser for Mason lexer #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dron22
reviewed
Nov 5, 2020
| @@ -0,0 +1 @@ | |||
| <& /path/to/comp.mi, name=>value &> | |||
There was a problem hiding this comment.
As re.DOTALL is used in the python version, can we add a test case, where this is split across multiple lines?
Suggested change
| <& /path/to/comp.mi, name=>value &> | |
| <& /path/to/comp.mi, | |
| name=>value &> |
There was a problem hiding this comment.
Sure. Already changed mason_calling_component.m to support it.
gandarez
force-pushed
the
mason-lexer-text-analysis
branch
from
08ba5b8
to
13100d7
Compare
dron22
approved these changes
Nov 6, 2020
|
PR opened to the maintainers. |
dron22
pushed a commit
that referenced
this pull request
Dec 8, 2020
Add set text analyser for Mason lexer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports pygments Mason text analysis to chroma/go. Original code can be found at: https://github.com/pygments/pygments/blob/master/pygments/lexers/templates.py#L566
The regex for
unnamed blocksseems to be wrong defined in Pygments. According to the official documentation aclassblock must be ended by a</%class>and not by</%class%>.Example here:
https://metacpan.org/pod/distribution/Mason/lib/Mason/Manual/Intro.pod#Email-generator-(from-script)
Fixes: wakatime/wakatime-cli#88