Force Squash nodejs install to use nodesource #5533
Conversation
Admin assets on Squash PR deployments are currently broken due to a problem running npm. This is the same issue previously reported in PR 5441. See nodesource/distributions issue 875 for the rationale behind this workaround; this ensures that nodejs is installed from nodesource instead of from the distro, which may have a newer version. As part of this change I've restored the Docker image back to `python:latest`, figuring we might as well do that if we can as opposed to pinning. Note that the somewhat ugly YAML syntax is needed due to issues including special characters like *&> in YAML.
Manage this branch in SquashTest this branch here: https://fix-squash-npm-f8o22.squash.io |
chosak
changed the title
There was a problem hiding this comment.
Thank you @chosak 🙂
The Squash team let me know they were working on a fix for this, so I’m not sure if we want to make this change. The risk I see in not pinning the dependency is that we’ll have build steps that will now be specific to Debian Buster, without actually explicitly depending on it. Same for the Python version – which is pinned everywhere else in our infrastructure, Circle CI, vagrant-wagtail-develop, and bakerydemo.
What do you think?
|
Yes, apparently this is now fixed on the Squash side. Should we update to |
|
@thibaudcolas thanks, I didn't realize that we were pinning everywhere else. In that case it makes sense to pin here as well. When you say that this is fixed on the Squash side, what does that mean? Will |
|
However it's been fixed on the Squash side, it looks like admin assets are working again, for example in #5538 opened yesterday. So this PR may no longer be needed. Closing unless/until such time as we need to revisit. |
Admin assets on Squash PR deployments are currently broken due to a problem running npm. This is the same issue previously reported in #5441. See nodesource/distributions#875 for the rationale behind this workaround; this ensures that nodejs is installed from nodesource instead of from the distro, which may have a newer version.
As part of this change I've restored the Docker image back to
python:latest, figuring we might as well do that if we can as opposed to pinning.Note that the somewhat ugly YAML syntax is needed due to issues including special characters like
*&>in YAML.I've tested this on my fork and it works correctly; hopefully this will work here too, in which case functionality can be tested by visiting the link that Squash posts below and confirming that the admin area properly includes static assets.