[WIP] Reformat whole codebase with black #5310
Conversation
Manage this branch in SquashTest this branch here: https://thibaudcolaschoreblack-format-vxw6y.squash.io |
|
I am super in favor of this, especially once psf/black#826 lands. |
|
Closing this now – it will happen, just not with this one PR :) |
|
Hey @thibaudcolas, Just curious whether you have considered picking this up again and/or if you want some help :) In case you’re unaware, Django has an accepted DEP for this. |
|
Hey @yhoiseth, good question! We had discussed this further than this PR suggests, but never took the time to share the outcome of those discussions. The TL;DR; is that we’d feel more comfortable making that change once Black is declared to be "stable", similarly to how Django has approached this. I’ve made an issue for this at #6056. Please follow up there if you have thoughts on those plans. |
|
P.S. @yhoiseth we would love your help :) |
Reformats the whole codebase with black, so we can assess whether we would want to do this or not. I've made this in three separate commits to make it easier to review:
If you want to review this, the most useful is probably to look at the diff without quote normalisation:
3b7f13a. I'd suggest also turning off whitespace diffs --> 3b7f13a?w=1.
I used black v19.3b0 for this, and relied on my shell's (zsh) expansion to figure out which files to target (
**/*.py).Here is a list of the formatted files:
Black output