Expose URL resolver match for RoutablePageMixin #11953
Open
+36
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django provides an `HttpRequest.resolver_match` attribute [0] that allows downstream code to inspect a request object to see how its URL was resolved to a view. Wagtail's RoutablePageMixin does its own sub-URL routing to call different view functions on a page object, but the resolver result isn't similarly made available. This commit sets a new `routable_resolver_match` attribute on the request object, akin to Django's `resolver_match`, that stores this sub-URL routing information for downstream use. Documentation has been updated appropriately (along with a couple of other minor broken things in the RoutablePageMixin docs). [0] https://docs.djangoproject.com/en/5.0/ref/request-response/#django.http.HttpRequest.resolver_match
Manage this branch in SquashTest this branch here: https://chosakfeatureroutable-resolver-vys1s.squash.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django provides an
HttpRequest.resolver_matchattribute that allows downstream code to inspect a request object to see how its URL was resolved to a view.Wagtail's RoutablePageMixin does its own sub-URL routing to call different view functions on a page object, but the resolver result isn't similarly made available.
This commit sets a new
routable_resolver_matchattribute on the request object, akin to Django'sresolver_match, that stores this sub-URL routing information for downstream use.Documentation has been updated appropriately (along with a couple of other minor broken things in the RoutablePageMixin docs):