Fix form action URL in user edit and delete views for custom user models #11951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://laymonagefix-user-edit-url-nejhg.squash.io |
Mistakenly removed in 83e7930
laymonage
force-pushed
the
fix-user-edit-url
branch
from
a9dd2eb
to
a99be93
Compare
gasman
added a commit
that referenced
this pull request
May 13, 2024
gasman
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on adding
UserViewSetcustomisation support, then I encountered this issue...83e7930 mistakenly removed the
context_object_namefrom theEditViewandDeleteView. Since the view still uses the custom templates that render the form action with a{% url %}instead of the availableedit_urlcontext variable, this results in the template being rendered with the current user as theuserthat is used to generate the URL. This only applies to installations where the auth user model'smodel_nameis notuser, so the bakerydemo is not affected.