Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wagtail Sphinx Theme Logo #288

Conversation

OsafAliSayed
Copy link
Contributor

Fixes: #287

Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will push a change that optimises this SVG and adds the variant (...-new) that does not have the word Wagtail.

@lb- lb- force-pushed the sayed/update/287-wagtail-sphinx-theme-logo-update branch from 36605f0 to 700c82a Compare March 23, 2024 21:44
@lb-
Copy link
Member

lb- commented Mar 23, 2024

Hmm. Ok. We may need to tweak this, looks like the current one has a white circle around it.

@lb- lb- force-pushed the sayed/update/287-wagtail-sphinx-theme-logo-update branch from 700c82a to 1ea6a49 Compare March 24, 2024 06:29
@lb-
Copy link
Member

lb- commented Mar 24, 2024

OK, looks like the logo new was all good as is, I have however renamed it to logo-circle so it's clearer what it's for + I have reduced the size by a few kb with an optimisation.

@lb- lb- merged commit 7b1b878 into wagtail:main Mar 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt latest Wagtail logo
2 participants