Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs config #284

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix readthedocs config #284

merged 1 commit into from
Feb 15, 2024

Conversation

laymonage
Copy link
Member

@laymonage laymonage commented Feb 15, 2024

Fixes #269

Add missing build.os key

https://blog.readthedocs.com/use-build-os-config/

We are announcing the deprecation of build.image config key in favor of build.os. Read the Docs will start requiring a build.os config key for all projects in order to build documentation successfully. We will start failing builds for projects not using “build.os” in their config file on October 16, 2023.

Also add setup commands to build frontend assets.

@laymonage
Copy link
Member Author

The readthedocs build now works!

And we can finally replicate the favicon issue: https://sphinx-wagtail-theme--284.org.readthedocs.build/en/284/examples/index.html

@laymonage laymonage merged commit 74d77a7 into main Feb 15, 2024
4 of 5 checks passed
@laymonage laymonage deleted the fix-readthedocs-build branch February 15, 2024 12:43
@lb-
Copy link
Member

lb- commented Feb 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

RTD site not updating
2 participants