Fix favicon URL #282
Merged
Fix favicon URL #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm looks like we can't rely on the Vercel preview, as the favicon works correctly there, even with the current Probably because readthedocs config for Wagtail would add the locale and version, whereas our config for this repo only has the latest version and without the locale. |
laymonage
force-pushed
the
fix-favicon-url
branch
from
71bb9a6
to
ec57b5c
Compare
|
OK, can confirm this fixes the issue: https://sphinx-wagtail-theme--282.org.readthedocs.build/en/282/examples/index.html 
Compare to current https://sphinx-wagtail-theme.readthedocs.io/en/latest/examples/index.html 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281