fix(deps): udpate commitlint monorepo to v12 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2021
BREAKING CHANGE: Remove support for lerna v2 and change the order of the `extends` resolution from right-to-left to left-to-right. Closes #97.
jdbruijn
force-pushed
the
fix/deps-commitlint
branch
from
20f30f8
to
8b0b095
Compare
|
The tests fails on both tests that use lerna , I haven't had time to look at it yet and I'm not familiar with the tests. @wagoid could you perhaps have a look at why these tests are failing? |
|
Okay, had a more in-depth look and it has to do with a change in |
|
I've got the fix too. I'll update this PR within an hour. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove support for lerna v2 and change the order of the
extendsresolution from right-to-left to left-to-right.Closes #97.