-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text regarding choosing between events and observable properties #2018
Conversation
I was a bit unsure where to put the explanation – so far, I added it to the bottom of the section on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the text addition is good. I have proposed a further distinction.
Regarding your question " or a more general section on best practices for TD design.". I feel that we have similar stuff in multiple places. Going forward, I think we can think of adding some tags for HTML elements that can be best practices. Like the implementation report, we can extract such best practices as a separate document for implementers. It can be a separate section but I fear that many texts can be too detached from their context. Definitely something to discuss in a call but the PR itself is fine.
efdb4a0
to
229e134
Compare
The PR is fine, will be merged async after rebasing |
3a47395
to
1ee9b68
Compare
Hmm, for some reason, the version I generate locally is now even more different from the main branch branch than before :/ To simplify things, I would simply remove my regeneration commit, and we could then have a clean version generated on the main branch, for example. |
1ee9b68
to
b5be054
Compare
I have merged my latest pr so maybe that messed it up. If you want, please create a new PR with the same changes and we can merge async |
Hmm, do you mean a PR that regenerates the current state on the main branch? Otherwise, I could also “wrap” the commit that adds the text to the |
Ok I have understood the problem. Basically, if you render, the index.html generated does not follow our prettify rules so it overwrites the previous formatting. Once I ran formatting after rendering, the unwanted changes were gone. I hope that we will not have these small but annoying issues with new tooling. |
Resolves #1818.
Preview | Diff