Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/inlines): support generic nullable type in inline var #4709

Merged
merged 2 commits into from May 14, 2024
Merged

fix(core/inlines): support generic nullable type in inline var #4709

merged 2 commits into from May 14, 2024

Conversation

nondebug
Copy link
Contributor

@nondebug nondebug commented May 10, 2024 •
edited by sidvishnoi

Fixes #4708

@sidvishnoi sidvishnoi changed the title Add test for |var:Generic<NullableType?>| fix(core/inlines): support generic nullable type in inline var May 12, 2024
sidvishnoi
sidvishnoi approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated tests failing, should wait for them to pass before merge.

@sidvishnoi
Copy link
Member

Will fix unrelated tests failing in Firefox separately.

@sidvishnoi sidvishnoi merged commit 046f651 into w3c:main May 14, 2024
7 of 8 checks passed
@nondebug nondebug mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic nullable type not rendered in inline var syntax
2 participants
@nondebug @sidvishnoi