perf(core/a11y): start loading axe earlier #3372

sidvishnoi · 2021-03-09T18:52:55Z

This will start fetching the axe script earlier, giving some performance improvements.
Also, should help in avoiding jasmine timeouts that we often get in CI [^1].

Extracted from #3319

[^1]

  Core — a11y
    ✖ allows overriding options (slow: 5.003 secs)
      Firefox 86.0 (Ubuntu 0.0.0)
    Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) in node_modules/jasmine-core/lib/jasmine-core/jasmine.js (line 7048)
    <Jasmine>

marcoscaceres · 2021-03-10T02:18:56Z

src/core/base-runner.js

@@ -43,6 +43,7 @@ function isRunnableModule(plug) {

 async function executePreparePass(runnables, config) {
  for (const plug of runnables.filter(p => p.prepare)) {
+    config.state[plug.name] = {};


Hmm... not a fan of attaching more stuff to config. Why not have this as an internal state inside the plugin itself?

Plugins can share state among them.
I plan to add a state arg to all functions, but conf.state was easier for starters.

I'd suggest doing that now... look at what happened with my terrible linter API :( I kept saying, "I'll fix it next week... I'll fix it next week..." and years later, still there 😢

sidvishnoi added 2 commits March 10, 2021 00:19

perf(core/a11y): start loading axe earlier

267bb21

nit: create empty state for each plugin in prepare for a bit of clarity

d7a4a69

sidvishnoi requested a review from marcoscaceres March 9, 2021 20:33

marcoscaceres reviewed Mar 10, 2021

View reviewed changes

sidvishnoi mentioned this pull request Mar 10, 2021

refactor(core/base-runner): replace conf.state with run(conf, state) #3373

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(core/a11y): start loading axe earlier #3372

perf(core/a11y): start loading axe earlier #3372

sidvishnoi commented Mar 9, 2021 •

edited

marcoscaceres Mar 10, 2021 •

edited

sidvishnoi Mar 10, 2021

marcoscaceres Mar 10, 2021

perf(core/a11y): start loading axe earlier #3372

Are you sure you want to change the base?

perf(core/a11y): start loading axe earlier #3372

Conversation

sidvishnoi commented Mar 9, 2021 • edited

marcoscaceres Mar 10, 2021 • edited

Choose a reason for hiding this comment

sidvishnoi Mar 10, 2021

Choose a reason for hiding this comment

marcoscaceres Mar 10, 2021

Choose a reason for hiding this comment

sidvishnoi commented Mar 9, 2021 •

edited

marcoscaceres Mar 10, 2021 •

edited