Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic nullable type not rendered in inline var syntax #4708

Closed
nondebug opened this issue May 10, 2024 · 1 comment · Fixed by #4709
Closed

Generic nullable type not rendered in inline var syntax #4708

nondebug opened this issue May 10, 2024 · 1 comment · Fixed by #4709
Labels
bug

Comments

@nondebug
Copy link
Contributor

Description of problem

URL to affected spec or repo:

w3c/gamepad#205 (review)

What happened (e.g., it crashed)?:

It wasn't recognized as a variable name:
image

If I remove the ? then it renders correctly.

Expected behavior (e.g., it shouldn't crash):

|gamepads| should be styled like a variable and should show the type sequence<Gamepad?> on hover.
@nondebug nondebug added the bug label May 10, 2024
@sidvishnoi
Copy link
Member

Can you send a PR with a test similar to #4685?

nondebug added a commit to nondebug/respec that referenced this issue May 10, 2024
@nondebug
Add test for |var:Generic<NullableType?>|
eb92f05 
Test for w3c#4708
@nondebug nondebug mentioned this issue May 10, 2024
Merged
@sidvishnoi sidvishnoi changed the title |gamepads:sequence&lt;Gamepad?&gt;| doesn't render correctly Generic nullable type not rendered in inline var syntax May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core/inlines): support generic nullable type in inline var nondebug/respec
2 participants
@sidvishnoi @nondebug