[css-font-loading-3][editorial] Reference WebIDL BufferSource #10309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have an affiliation set for the WhatWG repos (HTML, etc), but it doesn't looks like you guys are using the same system. Looks like I'll have to wait for someone to tell me how to fill out my organization on the w3c site for this to go through. |
|
Aha, we're not a W3c participating member (yet), so I created an account as myself |
Rather than defining a custom BinaryData typedef, the FontSource interface should just use the BufferSource definition from WebIDL. https://webidl.spec.whatwg.org/#BufferSource
ADKaster
force-pushed
the
font-loading-buffersource
branch
from
a16cf74
to
dd80529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than defining a custom BinaryData typedef, the FontSource interface should just use the BufferSource definition from WebIDL.
https://webidl.spec.whatwg.org/#BufferSource
I came across this implementing this API for the Ladybird Browser. Let me know if the issue is not as editorial as I think and needs an issue/meeting topic :).