Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap-2] Specify scroll-start-target #10227

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DavMila
Copy link
Contributor

@DavMila DavMila commented Apr 18, 2024

This adds details to the scroll-snap-2 spec[1] to specify scroll-start-target.

[1] https://drafts.csswg.org/css-scroll-snap-2

This adds details to the scroll-snap-2 spec[1] to specify
scroll-start-target.

[1] https://drafts.csswg.org/css-scroll-snap-2
@DavMila DavMila requested a review from flackr April 18, 2024 18:09
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@DavMila DavMila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggested changes, ptal, thanks.

@DavMila DavMila requested a review from flackr April 26, 2024 15:13
css-overflow-3/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
css-scroll-snap-2/Overview.bs Outdated Show resolved Hide resolved
David Awogbemila added 2 commits May 16, 2024 10:52
Define initial scroll position precedence in css-overflow-3.
De-vaguify post-first layout scroll-start-target & point to document
update process.
Extract scroll-view position algorithm for standalone use.
@DavMila DavMila requested a review from flackr May 16, 2024 15:08
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor, I think this is looking good, and extracting the algorithm to calculate the position that would scroll into view will be really useful for other spec changes coming.

css-overflow-3/Overview.bs Outdated Show resolved Hide resolved
cssom-view-1/Overview.bs Outdated Show resolved Hide resolved
David Awogbemila and others added 2 commits June 4, 2024 09:53
Replace scroll-view with scroll-into-view.
Mention and link css properties that change initial scroll position.
@DavMila DavMila self-assigned this Jun 4, 2024
@DavMila DavMila requested a review from tabatkins June 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants