Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Add eslint-html plugin #2109

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 3, 2021

Allows linting and autofixing of the script tags inside the HTML files

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2021

@zcorpan looks like the regression test token issue isn't fully resolved. Reading up some more from the error message https://github.community/t/github-actions-are-severely-limited-on-prs/18179/6, but you may as well disable it for now, so it doesn't turn other PRs red

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2021

FYI, people that are collaborators shouldn't have the failure, just people who try and fork and contribute, so maybe not too much of an issue

@zcorpan
Copy link
Member

zcorpan commented Nov 3, 2021

@nschonni it is an issue IMO, so I've disabled the workflow again. Tracking in #1811 (comment)

If you amend the last commit with no changes and force push the CI checks should re-run without the regression test coverage report check.

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2021

@zcorpan green again after the rebase

examples/listbox/listbox-collapsible.html Outdated Show resolved Hide resolved
Comment on lines 271 to 272
<script>sourceCode.add('sc1', 'ex1');
</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline + indentation 🙂 also below

Allows linting and autofixing of the script tags inside the HTML files
@howard-e howard-e merged commit f7de7ec into w3c:main Nov 5, 2021
@nschonni nschonni deleted the eslint-html branch November 5, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants