Modernize Blob constructor a tiny bit #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruisselbrink
approved these changes
Apr 9, 2019
|
I don't. I wanted to fix the general type setup, but I keep running out of time. |
|
need to close and reopen to trigger new travis |
bung2402
approved these changes
Nov 23, 2019
|
@annevk, could you please fix the merge conflicts? The constructor can now be updated to new syntax. |
|
Once there are sufficient tests I'm happy to address the remainder (including filing bugs). |
|
ok, no probs. Was worried about bit rot. How about just getting it to a good state and we just don't merge until there are tests? The only thing I was unsure about was the merge conflict with the algorithm, the IDL seems like a quick fix. |
All implementations do something different for new Blob(undefined, { type: "x/x" }). Let's do something simple.
Fixes #54.
annevk
force-pushed
the
annevk/blob-constructor
branch
from
abb6af3
to
07dc190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All implementations do something different for new Blob(undefined, { type: "x/x" }). Let's do something simple.
Fixes #54.
Preview | Diff