Taproot support #195
Taproot support #195
Conversation
| if payload.Program == nil { | ||
| return nil, errors.New("unable to compute taproot's tweaked key from payment data") | ||
| } | ||
|
|
||
| if len(payload.Program) != 32 { | ||
| return nil, errors.New("taproot's tweaked key has wrong length") | ||
| } |
There was a problem hiding this comment.
Do we really need these post checks? In general, this lib's methods make sure that everything's ok before doing any operation "by design", instead of performing post checks.
Is there a way to make these checks over the taproot data before doing the magic in order to make sure that at this point payload.Program is exactly a 32-bytes buffer?
There was a problem hiding this comment.
I think we need the first one if for any reasons the Program has not been computed from data, better to return a error instead of nil isn't it ?
about the length, it's almost the same reason, it's a kind of sanity check before returning the program (it ensures that if len is not 32, it won't fail during address computation)
But I agree, theorically the parse functions on taproot data should "validate" before taproot magic so maybe not useful
Don't think this is in the scope of the PR. We should open a dedicated ticket and discuss it there. |
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we verify signature? Is VerifyTaprootKeySpend/VerifyTaprootLeafCommitment? same in other test
There was a problem hiding this comment.
Not necessery in my opinion. VerifyTaprootLeafCommitment is tested in taproot pkg and broadcast is already a "sig check"
This PR adds Taproot/Tapscript support for elements, greatly inspired by the work already done on btcd: btcsuite/btcd#1787
1. bump btcd to latest, drop btcutils
btcsuite/btcd(including taproot PRs + schnorr support), go mod is pointing the latest commit hash. It seems to me that taproot changes has not been released yet (Am I wrong ?).2. Elements taproot
taprootpackage extends thebtcd/txscript/taprootfile and reuses the same unit test filetaproot_test.go. Lot of copy-paste there, the logic is the same on Elements. The major change is about BIP-341 hash tags (suffixed by "/elements" on Liquid).paymentpkg implements several new functions in order to support P2TR payments (unconfidential/confidential).blech32supports segwit v1 encoding (bech32m) + BONUS: add unit tests from liquidjs-libtransactionpkg implementsHashForWitnessV1.addresspkg (getScriptType, toOutputScript etc...).it closes #172
@altafan @tiero please review