fix: side effect when element turn from null to element #3904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
in
useMediaControls
, if the target element is assigned by a callback function, then the properties of the element will be set to the initial value of the refs.For example:
In this case, elRef will be set to unmuted
Additional context
I also considered to sync up internal refs with the target element if the element changes. While it changes the behavior, also the previous commit shows it was designed to overwrite new the element when the element changing.