Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(createInjectionState): add defaultValue option #3902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

melishev
Copy link
Contributor

@melishev melishev commented Apr 1, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

When using inject from vue, we can pass it a second argument defaultValue, which will help avoid problems and most importantly an error in the console that the provide context was not detected. I propose to extend createInjectionState to support this functionality

Additional context

Perhaps we should provide the ability to pass defaultValue not only when declaring a hook, but also when using useInjectedState.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 1, 2024
@melishev melishev force-pushed the main branch 2 times, most recently from c53d4da to 8f5c4a4 Compare April 1, 2024 11:25
@dvelikiy
Copy link

dvelikiy commented Apr 1, 2024

This is useful pls approve

@yakovlevgleb
Copy link

I need this!!!!

@cherkatya96
Copy link

Please, approve it!! I need it too!! 🤩

@mobdiz
Copy link

mobdiz commented Apr 1, 2024

This is a necessary feature for me 👍🏼

@melishev
Copy link
Contributor Author

melishev commented Apr 7, 2024

@Alfred-Skyblue can u check pls again?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@melishev
Copy link
Contributor Author

melishev commented Apr 9, 2024

@antfu bro, can you upload this PR, I'm getting tired of seeing warning in my console

@gevvos
Copy link

gevvos commented May 3, 2024

Hi, could someone please tell me when this PR will be merged? I need it for my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants