Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useMounted): The second argument in vue2.7 should be undefined #3830

Merged
merged 2 commits into from Mar 15, 2024

Conversation

yanbowe
Copy link
Contributor

@yanbowe yanbowe commented Feb 29, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

#3803

Additional context

@@ -13,7 +13,7 @@ export function useMounted() {
if (instance) {
onMounted(() => {
isMounted.value = true
}, isVue2 ? null : instance)
}, isVue2 ? void 0 : instance)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use undefined and let bundlers do their job by using void 0 if they want?

It's just my opinion, I prefer to read undefined, it's seems clearer to me.

Co-authored-by: Glandos <bugs-github@antipoul.fr>
@antfu antfu changed the title fix(useMounted): The second argument in vue2.7 should be void 0 fix(useMounted): The second argument in vue2.7 should be undefined Mar 15, 2024
@antfu antfu enabled auto-merge March 15, 2024 14:29
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 15, 2024
@antfu antfu added this pull request to the merge queue Mar 15, 2024
Merged via the queue into vueuse:main with commit 7966b85 Mar 15, 2024
8 checks passed
noook pushed a commit to noook/vueuse that referenced this pull request Mar 26, 2024
…ueuse#3830)

Co-authored-by: Anthony Fu <github@antfu.me>
Co-authored-by: Glandos <bugs-github@antipoul.fr>
@susnux
Copy link

susnux commented May 7, 2024

Is there any plan for a new vueuse release with this?

@qnp
Copy link

qnp commented May 15, 2024

Same, I'm looking forward to seeing this fix released, as I have errors that throw on my Vue2 project due to null target instead of undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants