Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useJwt)!: rename jwt_decode to jwtDecode #3510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

root5427
Copy link

@root5427 root5427 commented Oct 28, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Renamed jwt_decode to jwtDecode for compatibility with jwt-decode package's latest release


🤖 Generated by Copilot at 3a9fe5d

Updated the useJwt integration to use a newer API of jwt-decode. Fixed the import and usage of jwtDecode in packages/integrations/useJwt/index.ts.

🤖 Generated by Copilot at 3a9fe5d

  • Replace deprecated default export of jwt-decode with named export jwtDecode (link,link)

@root5427 root5427 closed this Oct 29, 2023
@root5427 root5427 deleted the patch-2 branch October 29, 2023 20:16
@root5427 root5427 restored the patch-2 branch October 29, 2023 20:17
@root5427 root5427 reopened this Oct 29, 2023
@TheVaan
Copy link

TheVaan commented Feb 18, 2024

Please merge this PR, as it upgrades jwt-decode to latest version! The latest version has several internal improvements in bundle size etc.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 18, 2024
Renamed `jwt_decode` to `jwtDecode` for compatibility with `jwt-decode` package's [latest release](https://github.com/auth0/jwt-decode/releases/tag/v4.0.0)

Solves vueuse#3508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHNAGE size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useJwt 不支持 jwt-decode 4.0(useJwt does not support jwt-decode 4.0)
5 participants