Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usePointerLock): new function #2590

Merged
merged 19 commits into from Jan 17, 2023
Merged

Conversation

daniser
Copy link
Contributor

@daniser daniser commented Dec 28, 2022

Description

Closes #2584.

this PR depends on following:

Additional context

I'm not sure if I should incapsulate mouse tracking into this so it'd provide { x, y } among other return values.
Because like 100% of time it'll be used with useMouse({ type: 'movement' }).
Right now I left this as it is for better separation of concerns, but I'd like to hear your opinion.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

wheatjs
wheatjs previously approved these changes Jan 1, 2023
@daniser daniser requested a review from wheatjs January 12, 2023 15:26
@wheatjs wheatjs enabled auto-merge (squash) January 17, 2023 07:31
@wheatjs wheatjs merged commit ae69fb8 into vueuse:main Jan 17, 2023
@daniser daniser deleted the feature/usePointerLock branch January 17, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usePointerLock function and useMouse enhancement
3 participants