Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make useGeolocation respect the immediate option #2525

Closed
wants to merge 1 commit into from

Conversation

khawarizmus
Copy link

@khawarizmus khawarizmus commented Dec 11, 2022

fixes #2524

Description

as described in #2524 this fix allows the useGeolocation to not be called immediatly

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ebisbe
Copy link
Contributor

ebisbe commented Dec 14, 2022

This is a duplicate of #2472

@khawarizmus
Copy link
Author

@ebisbe sorry I didn't see that. Can we have anyone of them merged? The changes are very simple and straightforward to review. And without this feature I find myself writing a more complicated code.

@antfu antfu closed this Dec 16, 2022
@antfu
Copy link
Member

antfu commented Dec 16, 2022

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useGeolocation immediate option is not working
3 participants