Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(createEeventHook): auto dispose #2518

Merged
merged 2 commits into from Dec 16, 2022
Merged

feat(createEeventHook): auto dispose #2518

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
693178f
Update createEventHook
ARZarkesh Dec 7, 2022
9842582
chore: update
antfu Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/shared/createEventHook/index.ts
View file
Open in desktop
Expand Up @@ -29,6 +29,10 @@ export function createEventHook<T = any>(): EventHook<T> {

const on = (fn: (param: T) => void) => {
fns.push(fn)

onScopeDispose(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onScopeDispose(() => {
tryOnScopeDispose(() => {

off(fn)
})

return {
off: () => off(fn),
Expand Down