feat: add reactive window.scrollTo watcher to useWindowScroll #2394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add watcher with
window.scrollTo
callback for exported x and y refs, so anyone can make whole page scroll with already exported refsAdditional context
Currently, exported
x
, andy
are simple writable refs, so I can write to them without any warning and with no side effect. It makes sense to either make them read-only (computed) or just addscrollTo
function to handle window scroll on changeThings that are not covered in this PR:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).