feat: add warn function #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree it's better to have this in the plugin directly, but would |
|
We don't have the stacktrace info available publicly in vue@2 and I wonder if it can be added |
|
I agree with this being added to the composition-api plugin |
|
Ok! I will move it to composition api next week then |
This was referenced Nov 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
warnfunction in Vue 3 adds a stacktrace so I think it's worth for library authors to be able to use it. However, it doesn't exist in Vue 2 (there isVue.util.warn, but it doesn't have a stacktrace)Because of this I thought of adding
warnto vue-demi, but maybe a better place would be the composition-api directly 馃 @pikax