Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VItem): support disabled effect #14941

Merged
merged 4 commits into from Jul 5, 2023
Merged

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Apr 8, 2022

fixes #14923

Description

fixes #14923

Motivation and Context

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-container>
    <v-item-group>
      <v-container>
        <v-row>
          <v-col
            v-for="n in 3"
            :key="n"
            cols="12"
            md="4"
          >
            <v-item 
                v-slot="{ active, toggle }"
                disabled
            >

              <v-card
                :color="active ? 'primary' : ''"
                class="d-flex align-center"
                dark
                height="200"
                @click="toggle"
              >
               <v-badge overlap>
                <template v-slot:badge>
                  <v-icon>mdi-magnify</v-icon>
                 </template>
                <v-icon>mdi-clipboard</v-icon>
              </v-badge> 
                  <v-scroll-y-transition>
                  <div
                    v-if="active"
                    class="text-h2 flex-grow-1 text-center"
                  >
                    Active
                  </div>
                </v-scroll-y-transition>
              </v-card>
            </v-item>
          </v-col>
        </v-row>

      </v-container>
    </v-item-group> 
      <!--  -->
  </v-container>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled items can still be tabbed to and activated with the keyboard, see #14229 and #14606.

@yuwu9145
Copy link
Member Author

yuwu9145 commented Apr 12, 2022

@KaelWD Thanks for the hints, pull request has been updated to cover both issues. In addition, playground markup code has been updated as well to simulate tab & click event from child elements

@johnleider johnleider self-requested a review January 17, 2023 17:10
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jan 17, 2023
@johnleider johnleider added this to the v3.1.x milestone Jan 17, 2023
@KaelWD KaelWD changed the base branch from master to v2-stable February 5, 2023 09:54
@johnleider johnleider modified the milestones: v3.1.x, v2.6.x Apr 19, 2023
@KaelWD KaelWD changed the base branch from v2-stable to v2-dev July 5, 2023 16:00
@KaelWD KaelWD modified the milestones: v2.6.x, v2.7.0 (Nirvana) Jul 5, 2023
@KaelWD KaelWD merged commit 415322d into vuetifyjs:v2-dev Jul 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VItem T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.6.4] v-item in v-item-group will not honor disabled prop
3 participants