Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VDataTable): add missing event as 3rd argument #14659

Closed
wants to merge 1 commit into from
Closed

feat(VDataTable): add missing event as 3rd argument #14659

wants to merge 1 commit into from

Conversation

Leinad4Mind
Copy link

@Leinad4Mind Leinad4Mind commented Jan 27, 2022 •
edited

Description

Add event as 3rd argument to click:row
fixes #10302, #9720

Motivation and Context

Since adding event as 1st argument would be an breaking change, we could at least add it as 3rd argument so we can at least make use of it in vuetify 2. The alternatives to make a click on each row have an huge impact on developing, since we need to add on all tables the item slot instead and add all the td's manually.

How Has This Been Tested?

There is already tests for this, same as dblclick event.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@Leinad4Mind Leinad4Mind changed the title fix(VDataTable): add missing event as 3rd argument feat((VDataTable): add missing event as 3rd argument Jan 27, 2022
@Leinad4Mind Leinad4Mind changed the title feat((VDataTable): add missing event as 3rd argument feat(VDataTable): add missing event as 3rd argument Jan 27, 2022
Add MouseEvent & KeyboardEvent to click:row
f447ad5 
feat(VDataTable): add event as 3rd argument

Change click:row event documentation

Add MouseEvent to click:row

Add KeyboardEvent to click:row
@johnleider johnleider added the S: on hold The issue is on hold until further notice label Jun 30, 2022
@KaelWD KaelWD changed the base branch from dev to v2-dev December 7, 2022 15:08
@KaelWD
Copy link
Member

KaelWD commented Dec 12, 2022

Missed this somehow, duplicated by #15864

@KaelWD KaelWD closed this Dec 12, 2022
@KaelWD KaelWD added duplicate The issue has already been reported S: on hold The issue is on hold until further notice and removed S: on hold The issue is on hold until further notice labels Dec 12, 2022
@Leinad4Mind
Copy link
Author

No problem. My code accepts keyboard event too and not only MouseEvents according the duplicated. Beaware of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate The issue has already been reported S: on hold The issue is on hold until further notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Leinad4Mind @KaelWD @johnleider