Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VData): reset sortBy & sortDesc when they are empty array #14561

Closed

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Jan 2, 2022

fixes #14423

Description

resolves #14423

Motivation and Context

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-content>
    <v-container fluid>
      <v-data-table
      :headers="headers"
      :items="desserts"
      :items-per-page="5"
      :sort-by.sync="sort.sortBy"
      :sort-desc.sync="sort.sortDesc"            
      class="elevation-1"
    ></v-data-table>
    </v-container>
  </v-content> 
  

</template>

<script>
export default {
  watch: {
    sort: {
      deep: true,
      immediate: true,
      handler(value) {
        const { sortBy, sortDesc } = value
        console.log({ sortBy, sortDesc})
      }
    }
  },
  data () {
    return {
      sort: {
        sortBy: '',
        sortDesc: false,
      },
      headers: [
        {
          text: 'Dessert (100g serving)',
          align: 'start',
          sortable: false,
          value: 'name',
        },
        { text: 'Calories', value: 'calories' },
        { text: 'Fat (g)', value: 'fat' },
        { text: 'Carbs (g)', value: 'carbs' },
        { text: 'Protein (g)', value: 'protein' },
        { text: 'Iron (%)', value: 'iron' },
      ],
      desserts: [
        {
          name: 'Frozen Yogurt',
          calories: 159,
          fat: 6.0,
          carbs: 24,
          protein: 4.0,
          iron: '1%',
        },
        {
          name: 'Ice cream sandwich',
          calories: 237,
          fat: 9.0,
          carbs: 37,
          protein: 4.3,
          iron: '1%',
        },
        {
          name: 'Eclair',
          calories: 262,
          fat: 16.0,
          carbs: 23,
          protein: 6.0,
          iron: '7%',
        },
        {
          name: 'Cupcake',
          calories: 305,
          fat: 3.7,
          carbs: 67,
          protein: 4.3,
          iron: '8%',
        },
        {
          name: 'Gingerbread',
          calories: 356,
          fat: 16.0,
          carbs: 49,
          protein: 3.9,
          iron: '16%',
        },
        {
          name: 'Jelly bean',
          calories: 375,
          fat: 0.0,
          carbs: 94,
          protein: 0.0,
          iron: '0%',
        },
        {
          name: 'Lollipop',
          calories: 392,
          fat: 0.2,
          carbs: 98,
          protein: 0,
          iron: '2%',
        },
        {
          name: 'Honeycomb',
          calories: 408,
          fat: 3.2,
          carbs: 87,
          protein: 6.5,
          iron: '45%',
        },
        {
          name: 'Donut',
          calories: 452,
          fat: 25.0,
          carbs: 51,
          protein: 4.9,
          iron: '22%',
        },
        {
          name: 'KitKat',
          calories: 518,
          fat: 26.0,
          carbs: 65,
          protein: 7,
          iron: '6%',
        },
      ],
    }
  },
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@yuwu9145 yuwu9145 marked this pull request as draft January 2, 2022 08:42
@yuwu9145 yuwu9145 marked this pull request as ready for review January 2, 2022 08:46
@KaelWD
Copy link
Member

KaelWD commented Jan 19, 2022

Fixed by 9cf48e4

Thanks, this wasn't really correct though. Resetting to [''] means that if you were using an array then it would never be empty. Simply removing the default value means undefined stays as undefined instead of being replaced with []

@KaelWD KaelWD closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.6.0] v-data-table sortBy / sortDesc attributes are not reset correctly
2 participants