Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): wrong alignment in RTL mode #14556

Merged
merged 2 commits into from Jan 19, 2022
Merged

Conversation

KareemDa
Copy link
Contributor

Description

fixes #12195

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-app id="inspire">
    <v-toolbar>
      <v-toolbar-items style="width: 100%">
        <v-spacer></v-spacer>
        <v-menu offset-y>
          <template v-slot:activator="{ on }">
            <v-btn class="ms-5" v-on="on">
              <span>Menu #2</span>
              <v-icon>mdi-menu-down</v-icon>
            </v-btn>
          </template>

          <v-list>
            <v-list-item>
              <v-list-item-title> item with basic content </v-list-item-title>
            </v-list-item>

            <v-list-item>
              <v-list-item-title>
                item with some of tooo looooong content that wont fit
              </v-list-item-title>
            </v-list-item>

            <v-list-item>
              <v-list-item-title> item with basic content </v-list-item-title>
            </v-list-item>
          </v-list>
        </v-menu>
        <v-spacer></v-spacer>

      </v-toolbar-items>
    </v-toolbar>
  </v-app>
</template>

<script>
export default {
  mounted () {
    this.$vuetify.rtl = true;
  },
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD merged commit 446963f into vuetifyjs:master Jan 19, 2022
@KaelWD KaelWD added this to the v2.6.x milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VMenu wrong alignment with RTL on
2 participants