Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VInput): allow text selection in disabled inputs #14465

Merged
merged 4 commits into from Jun 15, 2022
Merged

fix(VInput): allow text selection in disabled inputs #14465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8fcddc7
fix(VInput): disabled text selection
lentyaevpk Dec 6, 2021
5049371
fix(VAutocomplete, VCombobox): disabled text selection
lentyaevpk Dec 29, 2021
1661b6f
Merge branch 'master' into fix/disabled-input-text-selection
KaelWD Jun 15, 2022
6d3023e
fix: hide selection controls focus ring when disabled
KaelWD Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/vuetify/src/components/VAutocomplete/VAutocomplete.sass
View file
Open in desktop
Expand Up @@ -34,10 +34,6 @@
.v-select__slot > input
margin-top: $autocomplete-dense-enclosed-input-margin-top

&:not(.v-input--is-disabled).v-select.v-text-field
input
pointer-events: inherit

&__content.v-menu__content
border-radius: 0

Expand Down
7 changes: 2 additions & 5 deletions packages/vuetify/src/components/VInput/VInput.sass
View file
Open in desktop
Expand Up @@ -111,9 +111,6 @@
&--dense > .v-input__control > .v-input__slot
margin-bottom: $input-dense-slot-margin-bottom

&--is-disabled:not(.v-input--is-readonly)
pointer-events: none

&--is-loading > .v-input__control > .v-input__slot
&:before,
&:after
Expand All @@ -128,8 +125,8 @@

&--hide-spin-buttons
input::-webkit-outer-spin-button,
input::-webkit-inner-spin-button
input::-webkit-inner-spin-button
-webkit-appearance: none
margin: 0
input[type=number]
input[type=number]
-moz-appearance: textfield
4 changes: 3 additions & 1 deletion packages/vuetify/src/components/VSelect/VSelect.sass
View file
Open in desktop
Expand Up @@ -63,7 +63,6 @@
input
flex: 1 1 // Doesn't resize on IE11 with 3rd param
min-width: 0
pointer-events: none
position: relative

&:not(.v-text-field--single-line) input
Expand Down Expand Up @@ -118,6 +117,9 @@
.v-select__selections
flex-direction: row-reverse

&.v-input--is-disabled:not(.v-input--is-readonly):not(.v-autocomplete)
pointer-events: none

&__selections
align-items: center
display: flex
Expand Down
3 changes: 3 additions & 0 deletions packages/vuetify/src/styles/components/_selection-controls.sass
View file
Open in desktop
Expand Up @@ -109,6 +109,9 @@
.v-icon
color: inherit

&.v-input--is-disabled:not(.v-input--is-readonly)
pointer-events: none

.v-input--selection-controls__input:hover
.v-input--selection-controls__ripple:before
background: currentColor
Expand Down