Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTimelineItem): fix flickering on clickable v-card #14278

Closed

Conversation

ryoluo
Copy link

@ryoluo ryoluo commented Oct 14, 2021

fix #14193

Description

The bug was caused by style property of v-card--link::before. It can be resolved by adding wedge style to an element: .v-timeline-item__body > .v-card:not(.v-card--flat)::before.

fixes #14193

Motivation and Context

The change itself helps fixing an UI behavior (#14156)

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
    <v-app id="inspire">
      <v-timeline dense>
        <v-timeline-item>
          <v-card hover outlined :disabled="disable" @click="">
            <v-card-text>I flicker when the card is disabled. I have a click handler.</v-card-text>
          </v-card>
        </v-timeline-item>
        <v-timeline-item>
          <v-card hover outlined :disabled="disable">
            <v-card-text>I do not flicker. I do not have a click handler.</v-card-text>
          </v-card>
        </v-timeline-item>
      </v-timeline>
      <v-btn @click="disable = !disable" color="secondary">toggle disable</v-btn>
    </v-app>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      disable: false,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@glen-84 glen-84 added C: VTimeline VTimeline T: bug Functionality that does not work as intended/expected labels Oct 24, 2021
@ryoluo ryoluo requested a review from KaelWD October 24, 2021 16:06
@johnleider
Copy link
Member

The bottom image is the comparison with your changes.

image

@KaelWD
Copy link
Member

KaelWD commented Jun 15, 2022

Closing due to inactivity

@KaelWD KaelWD closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTimeline VTimeline T: bug Functionality that does not work as intended/expected
Projects
None yet
4 participants