Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vsimplecheckbox): fixes ripple behavior #14234

Closed
wants to merge 1 commit into from

Conversation

belov38
Copy link

@belov38 belov38 commented Oct 5, 2021

Fixes #12224

Description

Fixes #12224

Motivation and Context

Provided workaround hide only error meassage, but doesn't fix ripple effect.

How Has This Been Tested?

Visually in a new vue-cli "hello world" project

Markup:

<template>
  <v-container>
    <v-simple-checkbox v-model="v" />
    <div>
      <v-data-table :headers="headers" :items="desserts" class="elevation-1">
        <template v-slot:item.glutenfree="{ item }">
          <v-simple-checkbox v-model="item.glutenfree"></v-simple-checkbox>
        </template>
      </v-data-table>
    </div>
  </v-container>
</template>

<script>
export default {
  name: "HelloWorld",

  data: () => ({
    desserts: [
      {
        name: "Eclair",
        calories: 262,
        fat: 16.0,
        carbs: 23,
        protein: 6.0,
        iron: "7%",
        glutenfree: false,
      },
      {
        name: "Jelly bean",
        calories: 375,
        fat: 0.0,
        carbs: 94,
        protein: 0.0,
        iron: "0%",
        glutenfree: true,
      },
      {
        name: "Lollipop",
        calories: 392,
        fat: 0.2,
        carbs: 98,
        protein: 0,
        iron: "2%",
        glutenfree: true,
      },
      {
        name: "KitKat",
        calories: 518,
        fat: 26.0,
        carbs: 65,
        protein: 7,
        iron: "6%",
        glutenfree: false,
      },
    ],
    headers: [
      {
        text: "Dessert (100g serving)",
        align: "start",
        sortable: false,
        value: "name",
      },
      { text: "Calories", value: "calories" },
      { text: "Fat (g)", value: "fat" },
      { text: "Carbs (g)", value: "carbs" },
      { text: "Protein (g)", value: "protein" },
      { text: "Iron (%)", value: "iron" },
      { text: "Gluten-Free", value: "glutenfree" },
    ],
    v: false,
  }),
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@glen-84 glen-84 added C: VSimpleCheckbox T: bug Functionality that does not work as intended/expected labels Oct 24, 2021
@ferm10n
Copy link

ferm10n commented Nov 28, 2021

Why does the v-simple-checkbox have a problem with v-ripple, and not other components? do those components register it locally somehow?

@johnleider
Copy link
Member

This is not the way to solve this problem. Please come up with a different approach.

@johnleider johnleider marked this pull request as draft December 16, 2021 15:45
@KaelWD KaelWD closed this May 13, 2022
@KaelWD KaelWD added the invalid The issue is missing information or is not a valid bug/feature request label May 13, 2022
@KaelWD KaelWD added C: VCheckboxBtn VCheckboxBtn and removed C: VSimpleCheckbox labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCheckboxBtn VCheckboxBtn invalid The issue is missing information or is not a valid bug/feature request T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Failed to resolve directive: ripple
5 participants