Skip to content

Commit

Permalink
fix(VRadio): use correct disabled color for icons
Browse files Browse the repository at this point in the history
  • Loading branch information
@KaelWD
KaelWD committed Jun 15, 2022
1 parent 27ba2c9 commit 3115798
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/vuetify/src/components/VRadioGroup/VRadio.sass
View file
Expand Up @@ -6,10 +6,6 @@
label
color: map-deep-get($material, 'text', 'disabled')

.v-icon
// needed for helper override
color: map-deep-get($material, 'selection-controls', 'disabled') !important

.v-radio
align-items: center
display: flex
Expand Down

3 comments on commit 3115798

@jagers
Copy link

@jagers jagers commented on 3115798 Jul 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KaelWD This commit made it so that disabled radios are no longer greyed out - is that intentional?

All my radios buttons now look the same (show as primary color) regardless of whether they are disabled or not, which seems incorrect

@KaelWD
Copy link
Member Author

@KaelWD KaelWD commented on 3115798 Jul 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must've only tested <v-radio-group disabled> which does change the color. I don't recall what exactly the original context for this change was, there was no issue and I can't find any conversation about it in discord. It may have just been a follow up from 674fd5d when I noticed radios still had that override.

@KaelWD
Copy link
Member Author

@KaelWD KaelWD commented on 3115798 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0cc43e2

Please sign in to comment.