fix: replace conditional prop binding with ternary instead of &&

vuetifyjs · Apr 15, 2024 · a577bd0 · a577bd0
1 parent 2892491
commit a577bd0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/rules/no-deprecated-props.js b/src/rules/no-deprecated-props.js
@@ -722,7 +722,7 @@ module.exports = {
                       return [fixer.replaceText(propNameNode, replace.name), fixer.replaceText(attr.value, `"${value}"`)]
                     } else {
                       const expression = context.getSourceCode().getText(attr.value.expression)
-                      return [fixer.replaceText(propNameNode, replace.name), fixer.replaceText(attr.value, `"${expression} && '${value}'"`)]
+                      return [fixer.replaceText(propNameNode, replace.name), fixer.replaceText(attr.value, `"${expression} ? '${value}' : undefined"`)]
                     }
                   } else {
                     return fixer.replaceText(attr, `${replace.bind ? ':' : ''}${replace.name}="${value}"`)

diff --git a/tests/rules/no-deprecated-props.js b/tests/rules/no-deprecated-props.js
@@ -23,12 +23,12 @@ tester.run('no-deprecated-props', rule, {
     },
     {
       code: '<template><v-btn :outline="false" /></template>',
-      output: `<template><v-btn :variant="false && 'outlined'" /></template>`,
+      output: `<template><v-btn :variant="false ? 'outlined' : undefined" /></template>`,
       errors: [{ messageId: 'replacedWith' }],
     },
     {
       code: '<template><v-btn v-bind:outline="false" /></template>',
-      output: `<template><v-btn v-bind:variant="false && 'outlined'" /></template>`,
+      output: `<template><v-btn v-bind:variant="false ? 'outlined' : undefined" /></template>`,
       errors: [{ messageId: 'replacedWith' }],
     },
     {
@@ -73,7 +73,7 @@ tester.run('no-deprecated-props', rule, {
     },
     {
       code: '<template><v-window :vertical="condition" /></template>',
-      output: `<template><v-window :direction="condition && 'vertical'" /></template>`,
+      output: `<template><v-window :direction="condition ? 'vertical' : undefined" /></template>`,
       errors: [{ messageId: 'replacedWith' }],
     },
     {