Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git commit -am "fix(code-scss): 修复代码块行号与代码对应不齐问题 (close #901)" #902

Closed
wants to merge 1 commit into from
Closed

git commit -am "fix(code-scss): 修复代码块行号与代码对应不齐问题 (close #901)" #902

wants to merge 1 commit into from

Conversation

dingqianwen
Copy link

通过测试

@Mister-Hope
Copy link
Member

Any reason why it's 1.377 instead of 1.4? This is required before merging.

@dingqianwen
Copy link
Author

因为一点点尝试与测试，发现这个数是最标准的，无论代码块行数是多少都适应。

@Mister-Hope
Copy link
Member

#901 (comment)

Mister-Hope
Mister-Hope requested changes May 21, 2022
View reviewed changes
Copy link
Member

@Mister-Hope Mister-Hope left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason required before merging.

And the reason should be comment next to the changed line for further maintenance

@Mister-Hope
Copy link
Member

If you try vuepress-theme-hope, you can find that the code line is aligning, but I can tell you that I am using line-height: 1.4 as well,

image

The reason matters as we should try to make things clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-Hope Mister-Hope Mister-Hope requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dingqianwen @Mister-Hope