fix(keep-alive): fix keep-alive memory leak #9875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant1m4tt3r
reviewed
Apr 18, 2019
| @@ -120,5 +120,13 @@ export default { | |||
| vnode.data.keepAlive = true | |||
| } | |||
| return vnode || (slot && slot[0]) | |||
| }, | |||
| updated() { | |||
| const { cache } = this | |||
There was a problem hiding this comment.
Hello @dejour , just passing by and noticed that you can also destructure the _vnode property in this statemant, avoiding to use this._vnode on the line 127.
Also, the CI points a build failure on the test-cover and lint steps. I think it has nothing to do with your code, since the change it's not on you commit.
|
Thanks for the PR but we are closing this in favor of #9962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Vue component will not be recycled. because keep-alive cache vnode. and cached vnode will hold on to new parent vnode which will hold created vue instance. So we will use the updated hook to set all
cached vnode's parent to null. This pull request will fix #9842. In the original issue. it states that it relates to transition which is not true. It can be any vue component.Here is my local test.
before:
the more you update keep-alive, the more hierarchy you get.
after: