Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduler): getNow detection can randomly fail (fix #9632) #9667

Merged
merged 1 commit into from Mar 11, 2019
Merged

fix(scheduler): getNow detection can randomly fail (fix #9632) #9667

merged 1 commit into from Mar 11, 2019

Commits on Mar 10, 2019

  1. fix(scheduler): getNow detection can randomly fail 

    The previous detection code compared time stamps based on Date.now()
which are not monotonic, so the check could fail due to clock skew or
adjustments.

This fix changes the check to compare against performance.now() if it is
supported, because it is monotonic (strictly increasing).
    @felixbuenemann
    felixbuenemann committed Mar 10, 2019
    Copy the full SHA
    bc9394a View commit details
    Browse the repository at this point in the history